fix bug in milestone timestep implementation

festim-dev · Nov 15, 2024 · 8399a26 · 8399a26
1 parent 0769a6f
commit 8399a26
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/festim/stepsize.py b/src/festim/stepsize.py
@@ -141,7 +141,7 @@ def modify_value(self, value, nb_iterations, t=None):
             if updated_value > time_to_milestone and not np.isclose(
                 t, next_milestone, atol=0
             ):
-                updated_value = next_milestone
+                updated_value = time_to_milestone
 
         return updated_value
 

diff --git a/test/test_stepsize.py b/test/test_stepsize.py
@@ -185,7 +185,7 @@ def test_overshoot_milestone(nb_its=1, target=4):
         value=current_value, nb_iterations=nb_its, t=0.9
     )
 
-    expected_value = 1.3
+    expected_value = 1.3 - current_value
 
     assert new_value == expected_value