Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support optional InstallDir parameter. #265

Merged
merged 2 commits into from
Oct 27, 2017
Merged

Support optional InstallDir parameter. #265

merged 2 commits into from
Oct 27, 2017

Conversation

jdshkolnik
Copy link
Contributor

ferventcoder
ferventcoder requested changes Oct 27, 2017
View reviewed changes
Copy link
Owner

@ferventcoder ferventcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! It just needs one additional bit - the package must also take a dependency on the chocolatey-core.extension to ensure that Get-PackageParameters exists for folks that have not upgraded to Chocolatey v0.10.8 yet.

@jdshkolnik
Copy link
Contributor Author

@ferventcoder Which version would the dependency be for? 1.3.3?

@ferventcoder
Copy link
Owner

@jdshkolnik whatever the others use, if you add it as a minimum dependency, then it will use at least that (e.g. <dependency id="chocolatey-core.extension" version="1.1.0" />). Best to follow the advice at https://chocolatey.org/docs/how-to-parse-package-parameters-argument#built-in

@jdshkolnik
Copy link
Contributor Author

Dependency added.

@ferventcoder ferventcoder merged commit e1b52e7 into ferventcoder:master Oct 27, 2017
@ferventcoder
Copy link
Owner

Thanks!

GeneralBison pushed a commit to GeneralBison/chocolatey-packages that referenced this pull request Jun 3, 2021
@ferventcoder
Merge pull request ferventcoder#265 from jdshkolnik/master
1e7596a 
Support optional InstallDir parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferventcoder ferventcoder ferventcoder approved these changes

Assignees
No one assigned
Labels
Package Release(s) Needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdshkolnik @ferventcoder