Feat/kicking inactive #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add chat components
Feat/text - compilation errors fixed
|
someone help me with these merge conflicts please, it should take everything from my branch and discard everything otherwise and I'm not quite sure how to do that |
AnonymousBit0111
force-pushed
the
feat/kicking_inactive
branch
from
4946d11
to
b0f456f
Compare
|
dont merge yet, seems like because of the conflicts now it kicks even when the keep alive has been received |
|
for some reason the keep alive system suddenly stops running during a sleep, but the stop function is not called?????? |
There was a problem hiding this comment.
remove traces when random stop issue is fixed
|
looks like a deadlock... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR kicks inactive players and remove them from the universe
Description
Keep alives are now stored in the Incoming and Outgoing Keep alive packet, if the last incoming keep alive is not the same as the last outgoing one the client should be kicked and if a client fails to send a keep alive for 30 its also kicked, also now if it takes more than 2 seconds to read a packet the connection loop will skip to the next iteration to prevent the loop from hanging.
Motivation and Context
This change was implemented to make sure inactive or invalid clients are kicked
How has this been tested?
Ive connected to the server with two clients and disconnected them by turning off their internet, if I turn the interned back on within 30 seconds nothing happens, otherwise the client is kicked.
Screenshots (if appropriate):
Types of changes
Checklist: