Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved the state to it's own crate #115

Open
wants to merge 2 commits into
base: rewrite/v3
Choose a base branch
from

Conversation

ReCore-sys
Copy link
Collaborator

@ReCore-sys ReCore-sys commented Nov 3, 2024

This PR moves the ServerState and GlobalState types into it's own crate

Description

The definitions for the GlobalState and ServerState have been moved into it's own crate since it made very little sense to have it in the net crate. On the surface this seems like it would cause cyclic dependency issues but it won't actually introduce any more issues than having it in the net crate, other than preventing the net crate from providing types that are used in the state, but it wasn't doing that in the first place.

Motivation and Context

This change was implemented to clear up confusion regarding having the state implemented in the net crate.

How has this been tested?

Since it's just moving definitions from one place to another, no unit tests are required because if it compiles, it works.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (restructuring code, without changing its behavior)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • Clippy passes with no warnings.

@ReCore-sys ReCore-sys changed the title Moved the state to the ferrumc_core crate Moved the state to it's own crate Nov 5, 2024
Copy link
Contributor

@Skullians Skullians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants