Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): respect readonly schemas for example generation #5320

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

dsinghvi
Copy link
Member

@dsinghvi dsinghvi commented Dec 3, 2024

Description

By default, inlined requests respect the OpenAPI readonly flag. Referenced types do not unless respect-readonly-schemas is turned on.

Example generation now follows the logic above to prevent fern check errors.

Changes Made

The ExampleTypeFactory.ts was updated to account for inlined requests.

Testing

  • Unit tests added/updated
  • Manual testing completed

@dsinghvi dsinghvi marked this pull request as ready for review December 3, 2024 15:49
@dsinghvi dsinghvi enabled auto-merge (squash) December 3, 2024 15:54
@dsinghvi dsinghvi merged commit 26a301d into main Dec 3, 2024
51 checks passed
@dsinghvi dsinghvi deleted the dsinghvi/respect-readonly-example-generation branch December 3, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants