Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Generated examples omit optional fields when not explicitly set. #5303

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eyw520
Copy link
Contributor

@eyw520 eyw520 commented Nov 29, 2024

Description

Example generation previously generated optional fields when not explicitly set in specs (see Ntropy).

Changes Made

  • Explicitly pass in null into buildExampleHelper when field is missing from schema fullExample.
  • Required values are still generated when missing.

Testing

  • Unit tests added/updated
  • Manual testing completed

@eyw520 eyw520 marked this pull request as draft November 29, 2024 16:29
Copy link

\n🌿 Preview your docs: 🌿 Preview your docs: https://fern-preview-22c348a8-b6cb-4ea7-a816-b2ee9bf400b9.docs.buildwithfern.com/learn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant