Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): respect null examples when generating OpenAPI -> IR #5296

Merged
merged 5 commits into from
Nov 29, 2024
Merged

fix(cli): respect null examples when generating OpenAPI -> IR #5296

merged 5 commits into from
Nov 29, 2024

Conversation

eyw520
Copy link
Contributor

@eyw520 eyw520 commented Nov 28, 2024

Description

This fix aborts recursive example generation for values explicitly set to null.

Changes Made

  • Add conditional Object.is(example, null) check before proceeding with example generation.

Testing

  • Unit tests added/updated
  • Manual testing completed

@eyw520 eyw520 requested a review from chdeskur November 28, 2024 03:31
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2024 •
edited
Loading

🌿 Preview your docs: https://fern-preview-cebaea2f-01f1-4705-8a92-369ace96bd7f.docs.buildwithfern.com/learn

@eyw520 eyw520 merged commit 7ec059c into main Nov 29, 2024
53 checks passed
@eyw520 eyw520 deleted the eden/respect-null-examples branch November 29, 2024 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsinghvi dsinghvi dsinghvi approved these changes

@chdeskur chdeskur Awaiting requested review from chdeskur

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eyw520 @dsinghvi @fern-bot