feat(typescript): add outputProjectFiles option when generating locally
#5086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ally This adds a new option `outputProjectFiles` which, when generating an SDK locally, will output the entire project as opposed to just the source files. This option takes precedence over the `outputSourceFiles` option. Fixes fern-api#3257.
mstade
commented
Nov 3, 2024
Comment on lines
+127
to
+130
| await typescriptProject.copyProjectAsZipTo({ | ||
| logger, | ||
| destinationZip | ||
| }); |
There was a problem hiding this comment.
This is the key to outputting the project files locally. Because this option outputs the entire project, the outputSourceFiles option is essentially implied since the src directory is included in the project. That's why this should take priority.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option
outputProjectFileswhich, when generating an SDK locally, will output the entire project as opposed to just the source files. This option takes precedence over theoutputSourceFilesoption.Fixes #3257.
@coderabbitai summary