fix(cli): remove errant default values on primitives (date primitives) (

#5381) * remove errant default values on primitives (date primitives) * bump cli version * update snapshots * chore: update changelog * make non rc --------- Co-authored-by: fern-bot <[email protected]> Co-authored-by: fern-support <[email protected]>
fern-api · Dec 11, 2024 · a2aa8cf · a2aa8cf
1 parent d45e315
commit a2aa8cf
Show file tree

Hide file tree

Showing 18 changed files with 101 additions and 173 deletions.
diff --git a/fern/pages/changelogs/cli/2024-12-11.mdx b/fern/pages/changelogs/cli/2024-12-11.mdx
@@ -0,0 +1,4 @@
+## 0.45.4
+**`(fix):`** Defaults are no longer set on datetimes when converting to docs shapes.
+
+
diff --git a/packages/cli/cli/versions.yml b/packages/cli/cli/versions.yml
@@ -1,3 +1,10 @@
+- changelogEntry:
+    - summary: |
+        Defaults are no longer set on datetimes when converting to docs shapes.
+      type: fix
+  irVersion: 53
+  version: 0.45.4
+
 - changelogEntry:
     - summary: |
         Bumped Java IR to latest (v53)
@@ -23,7 +30,7 @@
     - summary: |
         Example generation now respects read-only schemas when generating request examples.
       type: fix
-  irVersion: 53
+  irVersion: 53 
   version: 0.45.2
 
 - changelogEntry:

diff --git a/...ster/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth-environment-variables.json b/...ster/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth-environment-variables.json
@@ -55,8 +55,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }
@@ -131,8 +130,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/basic-auth.json
@@ -55,8 +55,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }
@@ -131,8 +130,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }

diff --git a/...ages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/circular-references.json b/...ages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/circular-references.json
@@ -223,8 +223,7 @@
             "type": {
               "type": "primitive",
               "value": {
-                "type": "boolean",
-                "default": false
+                "type": "boolean"
               }
             }
           }

diff --git a/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json b/...register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto-exhaustive.json
@@ -703,8 +703,7 @@
             "type": {
               "type": "primitive",
               "value": {
-                "type": "boolean",
-                "default": false
+                "type": "boolean"
               }
             }
           }
@@ -956,8 +955,7 @@
                       "itemType": {
                         "type": "primitive",
                         "value": {
-                          "type": "boolean",
-                          "default": false
+                          "type": "boolean"
                         }
                       }
                     }
@@ -1448,8 +1446,7 @@
                       "itemType": {
                         "type": "primitive",
                         "value": {
-                          "type": "boolean",
-                          "default": false
+                          "type": "boolean"
                         }
                       }
                     }
@@ -1461,8 +1458,7 @@
                       "itemType": {
                         "type": "primitive",
                         "value": {
-                          "type": "boolean",
-                          "default": false
+                          "type": "boolean"
                         }
                       }
                     }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/csharp-grpc-proto.json
@@ -154,8 +154,7 @@
             "type": {
               "type": "primitive",
               "value": {
-                "type": "boolean",
-                "default": false
+                "type": "boolean"
               }
             }
           }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/custom-auth.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/custom-auth.json
@@ -55,8 +55,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }
@@ -131,8 +130,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }

diff --git a/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/examples.json b/packages/cli/register/src/ir-to-fdr-converter/__test__/__snapshots__/examples.json
@@ -222,8 +222,7 @@
                   "valueType": {
                     "type": "primitive",
                     "value": {
-                      "type": "base64",
-                      "default": "0"
+                      "type": "base64"
                     }
                   }
                 }
@@ -357,8 +356,7 @@
             "valueType": {
               "type": "primitive",
               "value": {
-                "type": "long",
-                "default": 0
+                "type": "long"
               }
             }
           }
@@ -533,8 +531,7 @@
             "valueType": {
               "type": "primitive",
               "value": {
-                "type": "date",
-                "default": "1970-01-01T00:00:00.000Z"
+                "type": "date"
               }
             }
           },
@@ -543,8 +540,7 @@
             "valueType": {
               "type": "primitive",
               "value": {
-                "type": "datetime",
-                "default": "1970-01-01T00:00:00.000Z"
+                "type": "datetime"
               }
             }
           }
@@ -998,8 +994,7 @@
                   "valueType": {
                     "type": "primitive",
                     "value": {
-                      "type": "boolean",
-                      "default": false
+                      "type": "boolean"
                     }
                   }
                 }
@@ -1016,8 +1011,7 @@
                   "valueType": {
                     "type": "primitive",
                     "value": {
-                      "type": "boolean",
-                      "default": false
+                      "type": "boolean"
                     }
                   }
                 }
@@ -1588,8 +1582,7 @@
               "value": {
                 "type": "primitive",
                 "value": {
-                  "type": "boolean",
-                  "default": false
+                  "type": "boolean"
                 }
               }
             }
@@ -1890,8 +1883,7 @@
                 "itemType": {
                   "type": "primitive",
                   "value": {
-                    "type": "boolean",
-                    "default": false
+                    "type": "boolean"
                   }
                 }
               }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,4 @@
		## 0.45.4
		`(fix):` Defaults are no longer set on datetimes when converting to docs shapes.