Fix extends spread in getReferences (#732)

fern-api · Sep 18, 2022 · 5dc1a46 · 5dc1a46
1 parent 873ed25
commit 5dc1a46
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 2 deletions.
diff --git a/packages/cli/ete-tests/src/tests/ir/__snapshots__/ir.test.ts.snap b/packages/cli/ete-tests/src/tests/ir/__snapshots__/ir.test.ts.snap
@@ -476,7 +476,20 @@ exports[`ir simple 1`] = `
                 "name": "RecursiveType"
             },
             "shape": {
-                "extends": [],
+                "extends": [
+                    {
+                        "name": "CreateMovieRequest",
+                        "fernFilepath": [
+                            {
+                                "originalValue": "imdb",
+                                "camelCase": "imdb",
+                                "snakeCase": "imdb",
+                                "pascalCase": "Imdb",
+                                "screamingSnakeCase": "IMDB"
+                            }
+                        ]
+                    }
+                ],
                 "properties": [
                     {
                         "name": {
@@ -511,6 +524,18 @@ exports[`ir simple 1`] = `
                 "_type": "object"
             },
             "referencedTypes": [
+                {
+                    "name": "CreateMovieRequest",
+                    "fernFilepath": [
+                        {
+                            "originalValue": "imdb",
+                            "camelCase": "imdb",
+                            "snakeCase": "imdb",
+                            "pascalCase": "Imdb",
+                            "screamingSnakeCase": "IMDB"
+                        }
+                    ]
+                },
                 {
                     "name": "RecursiveType",
                     "fernFilepath": [

diff --git a/packages/cli/ete-tests/src/tests/ir/fixtures/simple/fern/api/definition/imdb.yml b/packages/cli/ete-tests/src/tests/ir/fixtures/simple/fern/api/definition/imdb.yml
@@ -19,6 +19,7 @@ types:
       director: director.Director
       producer: {}
   RecursiveType:
+    extends: CreateMovieRequest
     properties:
       selfRefrencing: list<RecursiveType>
 errors:

diff --git a/...ion/ir-generator/src/converters/type-declarations/getReferencedTypesFromRawDeclaration.ts b/...ion/ir-generator/src/converters/type-declarations/getReferencedTypesFromRawDeclaration.ts
@@ -27,7 +27,11 @@ export function getReferencedTypesFromRawDeclaration({
         object: (objectDeclaration) => {
             const types: string[] = [];
             if (objectDeclaration.extends != null) {
-                types.push(...objectDeclaration.extends);
+                const extendsArr =
+                    typeof objectDeclaration.extends === "string"
+                        ? [objectDeclaration.extends]
+                        : objectDeclaration.extends;
+                types.push(...extendsArr);
             }
             if (objectDeclaration.properties != null) {
                 types.push(