fix(python): respect serialization with more types and dump JSON corr…

…ectly (#4694)

generators/python/core_utilities/shared/serialization.py

@@ -69,6 +69,24 @@ def convert_and_respect_annotation_metadata(
     if typing_extensions.is_typeddict(clean_type) and isinstance(object_, typing.Mapping):
         return _convert_mapping(object_, clean_type, direction)
 
+    if (
+        typing_extensions.get_origin(clean_type) == typing.Dict
+        or typing_extensions.get_origin(clean_type) == dict
+        or clean_type == typing.Dict
+    ) and isinstance(object_, typing.Dict):
+        key_type = typing_extensions.get_args(clean_type)[0]
+        value_type = typing_extensions.get_args(clean_type)[1]
+
+        return {
+            key: convert_and_respect_annotation_metadata(
+                object_=value,
+                annotation=annotation,
+                inner_type=value_type,
+                direction=direction,
+            )
+            for key, value in object_.items()
+        }
+
     # If you're iterating on a string, do not bother to coerce it to a sequence.
     if not isinstance(object_, str):
         if (
@@ -101,7 +119,6 @@ def convert_and_respect_annotation_metadata(
             )
             and isinstance(object_, typing.Sequence)
         ):
-
             inner_type = typing_extensions.get_args(clean_type)[0]
             return [
                 convert_and_respect_annotation_metadata(

generators/python/sdk/Dockerfile

@@ -5,7 +5,6 @@ ENV NODE_VERSION=18.20.1
 RUN apt install -y curl
 RUN curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.39.0/install.sh | bash
 ENV NVM_DIR=/root/.nvm
-RUN . "$NVM_DIR/nvm.sh" && nvm ls-remote
 RUN . "$NVM_DIR/nvm.sh" && nvm install ${NODE_VERSION}
 RUN . "$NVM_DIR/nvm.sh" && nvm use v${NODE_VERSION}
 RUN . "$NVM_DIR/nvm.sh" && nvm alias default v${NODE_VERSION}
@@ -34,8 +33,8 @@ RUN poetry install
 
 ENTRYPOINT ["python", "-m", "src.fern_python.generators.sdk.cli"]
 
-## NOTE: Uncomment the below to generate a flame graph for the python generator. 
-##       To visualize the flamegraph you can run: 
+## NOTE: Uncomment the below to generate a flame graph for the python generator.
+##       To visualize the flamegraph you can run:
 ##         - poetry add snakeviz
 ##         - poetry run snakeviz output.prof
 # RUN mkdir -p /fern/output

generators/python/sdk/versions.yml

@@ -1,4 +1,11 @@
 # For unreleased changes, use unreleased.yml
+- version: 4.2.6
+  irVersion: 53
+  changelogEntry:
+    - type: fix
+      summary: |
+        Serialization utilities (necessary when pydantic aliases are removed) now respects dictionaries as well.
+
 - version: 4.2.5
   irVersion: 53
   changelogEntry:

generators/python/src/fern_python/snippet/snippet_writer.py

@@ -1,4 +1,3 @@
-import json
 from typing import Any, Dict, List, Optional
 
 import fern.ir.resources as ir_types
@@ -262,7 +261,14 @@ def _get_snippet_for_unknown(
         self,
         unknown: Any,
     ) -> AST.Expression:
-        return AST.Expression(json.dumps(unknown))
+        if unknown is not None:
+
+            def write_unknown(writer: AST.NodeWriter) -> None:
+                maybe_stringify_unknown = repr(unknown) if type(unknown) is str else unknown
+                writer.write_line(f"{maybe_stringify_unknown}")
+
+            return AST.Expression(AST.CodeWriter(write_unknown))
+        return AST.Expression("None")
 
     def _get_snippet_for_list_or_set(
         self,