Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of old non-factors code #2749

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Get rid of old non-factors code #2749

merged 1 commit into from
Aug 23, 2024

Conversation

rylev
Copy link
Collaborator

@rylev rylev commented Aug 22, 2024

This deletes the following:

  • trigger, trigger-http, and trigger-redis`
  • All the old "host-component" crates
  • spin-testing that was only be used in one place, the spin-oci crate (we'll need to find a replacement for that test)
  • builds of several test apps that I believe are no longer used anywhere

Some notes:

  • We haven't yet ported trigger-redis over to factors, but I think it's fine if we delete the existing crate (we have git history)
  • We needed to comment out a dependency of the timer trigger example, but that didn't build anyway. We'll need to port it to factors.
  • We'll want to rename crates (e.g., trigger2 -> trigger), but I'll do that in a follow up.

@rylev rylev requested a review from lann August 22, 2024 16:48
@rylev rylev merged commit 6db2872 into factors Aug 23, 2024
2 checks passed
@rylev rylev deleted the mass-delete branch August 23, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants