ci(release): consolidate GH release logic #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajatjindal
reviewed
Dec 18, 2023
| - name: create GitHub release (canary) | ||
| if: github.ref == 'refs/heads/main' | ||
| run: | | ||
| gh release delete canary --cleanup-tag |
There was a problem hiding this comment.
+100 for using gh cli instead of third party actions for creating canary release
- use gh cli - only create release once all assets are ready Signed-off-by: Vaughn Dice <[email protected]>
|
@rajatjindal I've rebased this branch from main; PTAL when convenient. |
rajatjindal
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workflow runs/releases from this PR:
Fixes #2049