Skip to content

Commit

Permalink
masked the spin trigger http usage message
Browse files Browse the repository at this point in the history
Signed-off-by: Dipankar Das <[email protected]>
  • Loading branch information
dipankardas011 committed Jul 20, 2023
1 parent ea6ed76 commit ef24e99
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 9 deletions.
2 changes: 1 addition & 1 deletion crates/trigger/src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ pub const SPIN_WORKING_DIR: &str = "SPIN_WORKING_DIR";

/// A command that runs a TriggerExecutor.
#[derive(Parser, Debug)]
#[clap(next_help_heading = "TRIGGER OPTIONS")]
#[clap(usage="spin [COMMAND] [OPTIONS]",next_help_heading = "TRIGGER OPTIONS")]
pub struct TriggerExecutorCommand<Executor: TriggerExecutor>
where
Executor::RunConfig: Args,
Expand Down
2 changes: 1 addition & 1 deletion examples/config-rust/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 1 addition & 7 deletions src/commands/up.rs
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,6 @@ impl UpCommand {
};

self.run_trigger(trigger_cmd, Some(run_opts)).await
// return match self.run_trigger(trigger_cmd, Some(run_opts)).await {
// Ok(x) => Ok(x),
// Err(_) => Result::Err(anyhow!("spin up [OPTIONS]")),
// }
}

async fn run_trigger(
Expand All @@ -181,7 +177,7 @@ impl UpCommand {

cmd.env(SPIN_LOCKED_URL, locked_url)
.env(SPIN_WORKING_DIR, &working_dir)
.args(&self.trigger_args); // FIXME: due to this
.args(&self.trigger_args);

if let Some(local_app_dir) = local_app_dir {
cmd.env(SPIN_LOCAL_APP_DIR, local_app_dir);
Expand All @@ -206,8 +202,6 @@ impl UpCommand {
})?;
}

// FIXME: Here it is failing
println!("{:?}", cmd);
let status = child.wait()?;
if status.success() {
Ok(())
Expand Down

0 comments on commit ef24e99

Please sign in to comment.