Skip to content

Commit

Permalink
Merge pull request #2680 from fermyon/rust-1-80-changes
Browse files Browse the repository at this point in the history
Changes need to make Rust and Clippy happy on Rust 1.80
  • Loading branch information
rylev authored Jul 25, 2024
2 parents ca22ddc + de890c2 commit 1effaa2
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 13 deletions.
8 changes: 4 additions & 4 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions crates/componentize/src/abi_conformance/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@
//! (i.e. inbound requests) or by the host (i.e. outbound requests).
//!
//! - For a guest-implemented function, the host will call the function and assert the result matches what is
//! expected (see [`Report::inbound_http`] for an example).
//! expected (see [`Report::inbound_http`] for an example).
//!
//! - For a host-implemented function, the host will call a guest-implemented function according to the specified
//! [`InvocationStyle`] with a set of arguments indicating which host function to call and with what arguments.
//! The host then asserts that host function was indeed called with the expected arguments (see
//! [`Report::http`] for an example).
//! [`InvocationStyle`] with a set of arguments indicating which host function to call and with what arguments.
//! The host then asserts that host function was indeed called with the expected arguments (see
//! [`Report::http`] for an example).

#![deny(warnings)]

Expand Down Expand Up @@ -88,7 +88,7 @@ pub struct TestConfig {
/// - Guest-implemented exports which behave as prescribed by the test (e.g. `inbound_http` and `inbound_redis`)
///
/// - Host-implemented imports which are called by the guest with the arguments specified by the host
/// (e.g. `http`)
/// (e.g. `http`)
#[derive(Serialize, PartialEq, Eq, Debug)]
pub struct Report {
/// Result of the Spin inbound HTTP test
Expand Down
1 change: 0 additions & 1 deletion crates/core/tests/integration_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ async fn test_host_component_data_update() {
}

#[tokio::test(flavor = "multi_thread")]
#[cfg(not(tarpaulin))]
async fn test_panic() {
let err = run_core_wasi_test(["panic"], |_| {}).await.unwrap_err();
let trap = err.downcast::<Trap>().expect("trap");
Expand Down
2 changes: 1 addition & 1 deletion crates/key-value-azure/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ pub enum KeyValueAzureCosmosAuthOptions {
///
/// Common across each:
/// - `AZURE_AUTHORITY_HOST`: (optional) the host for the identity provider. For example, for Azure public cloud the host defaults to "https://login.microsoftonline.com".
/// See also: https://github.com/Azure/azure-sdk-for-rust/blob/main/sdk/identity/README.md
/// See also: https://github.com/Azure/azure-sdk-for-rust/blob/main/sdk/identity/README.md
Environmental,
}

Expand Down
2 changes: 1 addition & 1 deletion crates/trigger/src/runtime_config.rs
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ impl TriggerHooks for SummariseRuntimeConfigHook {
for (id, opt) in &opt.sqlite_databases {
opts.push(Self::summarise_sqlite(id, opt));
}
for opt in &opt.llm_compute {
if let Some(opt) = &opt.llm_compute {
opts.push(Self::summarise_llm(opt));
}
}
Expand Down
1 change: 0 additions & 1 deletion tests/integration.rs
Original file line number Diff line number Diff line change
Expand Up @@ -1038,7 +1038,6 @@ route = "/..."

/// Build an app whose component `workdir` is a subdirectory.
#[test]
#[cfg(not(tarpaulin))]
fn test_build_command_nested_workdir() -> anyhow::Result<()> {
do_test_build_command("tests/testcases/nested-build")
}
Expand Down

0 comments on commit 1effaa2

Please sign in to comment.