Make trigger importable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sven Pfennig <[email protected]>
itowlson
approved these changes
Dec 5, 2023
|
@0xE282B0 Totally in scope. I had been meaning to do this to the timer sample as well so that I could do a post on multiple trigger types in Lepton; we should establish this as the pattern for custom triggers going forward. Thanks for tackling this! |
|
Hey @itowlson, could we merge this PR & cut a new release so we can update the dependency in the containerd shim PR deislabs/containerd-wasm-shims#192 🙌 |
|
@leonardpahlke Sorry about that! I'll get a release under way. |
|
Awesome! I will update the shim PR accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @itowlson,
@leonardpahlke added the SQS trigger to the spin containerd shim as an example of how to add a trigger: deislabs/containerd-wasm-shims#192. To import the
SqsTriggerwe had to create alib.rsand move all the functionality except the main function there.Is this something you can see in the scope of this crate?