Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cron character explanation and give examples of different schedules #17

Merged
merged 6 commits into from
May 17, 2024

Conversation

tpmccallum
Copy link
Contributor

Signed-off-by: tpmccallum [email protected]

README.md Outdated Show resolved Hide resolved
Signed-off-by: tpmccallum [email protected]

Signed-off-by: Timothy McCallum <[email protected]>
Copy link
Contributor

@itowlson itowlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but otherwise LGTM

README.md Outdated
The `cron_expression` format for scheduling is as follows:

```text
sec min hour day of month month day of week year
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't actually part of the expression is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yes. I have updated so that we refer to the sec, min etc. as fields. I also use a bit of ascii-art inspired text to show each of the fields.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tpmccallum and others added 4 commits May 17, 2024 14:28
Signed-off-by: tpmccallum [email protected]

Co-authored-by: itowlson <[email protected]>
Signed-off-by: Timothy McCallum <[email protected]>
Signed-off-by: tpmccallum [email protected]

Co-authored-by: itowlson <[email protected]>
Signed-off-by: Timothy McCallum <[email protected]>
Signed-off-by: tpmccallum [email protected]

Co-authored-by: itowlson <[email protected]>
Signed-off-by: Timothy McCallum <[email protected]>
Signed-off-by: tpmccallum [email protected]

Signed-off-by: Timothy McCallum <[email protected]>
@tpmccallum tpmccallum merged commit 3589866 into main May 17, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants