Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Rust 1.78 template woe #15

Merged
merged 1 commit into from
May 12, 2024
Merged

Fix Rust 1.78 template woe #15

merged 1 commit into from
May 12, 2024

Conversation

itowlson
Copy link
Contributor

Fixes #8

@itowlson
Copy link
Contributor Author

Note this requires Spin 2.5 so we need to make sure we have template tags for Spin 2.3 and Spin 2.4 to not pick this up

@itowlson
Copy link
Contributor Author

Has someone set up a required check on ubuntu-latest but no build step that goes with it?

@itowlson
Copy link
Contributor Author

@rajatjindal do you have powers to override or fix the stuck check? Thanks!

@endocrimes
Copy link
Member

Fixed

@itowlson itowlson merged commit 28b14ed into fermyon:main May 12, 2024
7 checks passed
@itowlson
Copy link
Contributor Author

Thank you @endocrimes!

@rajatjindal
Copy link

@rajatjindal do you have powers to override or fix the stuck check? Thanks!

Hi Ivan, sorry I was OOO on Friday and do not have enough permissions anyways :).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fibonacci1729 fibonacci1729 fibonacci1729 approved these changes

@karthik2804 karthik2804 Awaiting requested review from karthik2804

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

spin-trigger-cron is not compiling with # rustc --version rustc 1.78.0-beta.1 (efd9d2df1 2024-03-18)
4 participants
@itowlson @endocrimes @rajatjindal @fibonacci1729