Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spin dependencies #44

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Update Spin dependencies #44

merged 1 commit into from
Sep 17, 2024

Conversation

rylev
Copy link
Contributor

@rylev rylev commented Sep 16, 2024

This also updates some other dependencies and deletes some unused code.

Copy link
Contributor

@karthik2804 karthik2804 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one teeny nit.

README.md Outdated
@@ -30,5 +30,5 @@ Alternatively, use the `spin pluginify` plugin to install from a fresh build. Th
```sh
spin plugins install pluginify
cargo build --release
spin pluginify install
spin pluginify
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just creates the plugin, need the install argument to actually install it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.. I got an error "unknown command 'install'" when I ran this. I thought I had the latest version of pluginify but perhaps not?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad. It is a -i flag

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I pushed a change.

Signed-off-by: Ryan Levick <[email protected]>
@rylev rylev merged commit 7ba166f into main Sep 17, 2024
8 checks passed
@rylev rylev deleted the update-spin branch September 17, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants