Update to handle new conformance tests #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
force-pushed
the
new-conformance
branch
2 times, most recently
from
892024a
to
bdf09c6
Compare
Signed-off-by: Ryan Levick <[email protected]>
lann
reviewed
Jun 17, 2024
Comment on lines
+5
to
+6
| // We don't use port 80 because URL parsing treats port 80 special | ||
| // and will not include it in the URL string representation which breaks the test |
There was a problem hiding this comment.
Will this be fixed by bytecodealliance/wasmtime#8563 ?
There was a problem hiding this comment.
I think we'll still run into because we're parsing the URL in the test component.
lann
reviewed
Jun 17, 2024
There was a problem hiding this comment.
As usual, moving large chunks of code in commits that also change that code (?) makes review difficult. As in, I didn't review this file. 😅
I'm sure I have never been guilty of this in the past week.
There was a problem hiding this comment.
Sorry about this! There were a few additions, but I believe besides that nothing changed.
lann
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the conformance tests to run fermyon/conformance-tests#2
This required adding one feature to
spin-test. Now thehttp-handlerinterface allows the user to not only specify an exact response for a given URL, but they can instead request that the request is echoed back as a response. This makes mocking thehttp-echoservice much easier and can be useful for testing.