Merge pull request #104 from fermyon/mqtt

Add mqtt conformance tests
fermyon · Jul 2, 2024 · 74f0ee9 · 74f0ee9
2 parents f082845 + 275e757
commit 74f0ee9
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/Cargo.lock b/Cargo.lock
diff --git a/conformance-tests/src/main.rs b/conformance-tests/src/main.rs
@@ -31,6 +31,7 @@ fn run_test(test: conformance_tests::Test) -> Result<(), anyhow::Error> {
             conformance_tests::config::Precondition::KeyValueStore(_) => {}
             conformance_tests::config::Precondition::Sqlite => {}
             conformance_tests::config::Precondition::Redis => {}
+            conformance_tests::config::Precondition::Mqtt => {}
         }
     }
     for invocation in test.config.invocations {

diff --git a/crates/spin-test-virt/src/lib.rs b/crates/spin-test-virt/src/lib.rs
@@ -637,8 +637,15 @@ impl mqtt::GuestConnection for MqttConnection {
         password: String,
         keep_alive_interval_in_secs: u64,
     ) -> Result<mqtt::Connection, mqtt::Error> {
-        let _ = (address, username, password, keep_alive_interval_in_secs);
-        Err(mqtt::Error::Other("not yet implemented".to_string()))
+        let url_allowed = manifest::AppManifest::allows_url(&address, "mqtt")
+            .map_err(|_| mqtt::Error::InvalidAddress)?;
+        if !url_allowed {
+            return Err(mqtt::Error::ConnectionFailed(format!(
+                "address {address} is not permitted"
+            )));
+        }
+        let _ = (username, password, keep_alive_interval_in_secs);
+        Ok(mqtt::Connection::new(MqttConnection))
     }
 
     fn publish(
@@ -648,7 +655,7 @@ impl mqtt::GuestConnection for MqttConnection {
         qos: mqtt::Qos,
     ) -> Result<(), mqtt::Error> {
         let _ = (topic, payload, qos);
-        Err(mqtt::Error::Other("not yet implemented".to_string()))
+        Ok(())
     }
 }