Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add templates for redis #286

Merged
merged 2 commits into from
Sep 3, 2024
Merged

Conversation

karthik2804
Copy link
Collaborator

@karthik2804 karthik2804 commented Aug 29, 2024

This should probably be merged after #287 and bump the versions in the templates.

Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
@karthik2804
Copy link
Collaborator Author

Are we okay with expecting a user to implement the class and export an object? If not, we could potentially add a spin.ts as we do for the http templates and wrap all that up where the user can just export one function.

@radu-matei
Copy link
Member

Given they're technically part of the same SDK, I'd like the two to be consistent.

@karthik2804
Copy link
Collaborator Author

One part I would like to note though is that - the http handler uses the built in fetchEvent while redis and anything else would end up using generated bindings.

@radu-matei radu-matei merged commit 340f62d into fermyon:main Sep 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants