catch exceptions in handler function and wait until handler completes #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthik2804
force-pushed
the
handle_errors
branch
from
b179657
to
646c227
Compare
|
@tschneidereit I have made the change as discussed. |
karthik2804
commented
Jul 18, 2024
Comment on lines
22
to
25
| // In case you want to do sonme work after the response is sent | ||
| // uncomment the line below and comment out the line with | ||
| // `await handler(event.request, res) | ||
| // event.waitUntil(handler(event.request, res)) |
There was a problem hiding this comment.
happy to replace this with a boolean and if...else statement if that would be cleaner.
radu-matei
reviewed
Jul 19, 2024
| @@ -18,7 +18,16 @@ async function handleEvent(event: FetchEvent) { | |||
|
|
|||
| let res = new ResponseBuilder(resolve); | |||
|
|
|||
| await handler(event.request, res) | |||
| try { | |||
| // In case you want to do sonme work after the response is sent | |||
radu-matei
reviewed
Jul 19, 2024
| try { | ||
| // In case you want to do sonme work after the response is sent | ||
| // uncomment the line below and comment out the line with | ||
| // `await handler(event.request, res) |
radu-matei
reviewed
Jul 19, 2024
| } catch (e: any) { | ||
| res.status(500) | ||
| res.send(`error in handler: ${e}`) | ||
| } | ||
| } | ||
|
|
||
| // Keep wizer happy during pre-init. Should go away |
There was a problem hiding this comment.
missing space on the line below
There was a problem hiding this comment.
The issue linked here is closed -- is this still needed?
There was a problem hiding this comment.
I will clean it up. Thoughts on the comment vs using a if...else if you want to continue processing after response has been sent back?
There was a problem hiding this comment.
I don't really have a preference.
There was a problem hiding this comment.
leaving it as a comment, since it is a template, we can change it if we feel the need for it.
karthik2804
force-pushed
the
handle_errors
branch
from
646c227
to
b847c6f
Compare
…function is complete Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
handle_errors
branch
from
b847c6f
to
07fb190
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
try...catchto the template so that any unhandled exceptions are caught and returned as an error instead of the generic error along the lines ofevent loop error - both task and job queues are empty, but expected operations did not resolveInternal error.This PR also modifies the template so that there is an
event.waitUntillon the handler function so that applications can do some work even after the response is sent.