Add llm #187
Merged
Add llm #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
approved these changes
Sep 4, 2023
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
add_llm
branch
3 times, most recently
from
157d553
to
d3d447e
Compare
rylev
reviewed
Sep 5, 2023
| top_p: f32, | ||
| } | ||
|
|
||
| fn llm_inference_with_options(context: &Context, _this: &Value, args: &[Value]) -> Result<Value> { |
There was a problem hiding this comment.
Are we sure we want this? We do this in Rust because Rust doesn't have optional args, but in JS it feels much more idiomatic to just have one function.
There was a problem hiding this comment.
Seeing now that the JS code differentiates these two functions. We should clean this up in a follow-up PR.
rylev
approved these changes
Sep 5, 2023
Signed-off-by: karthik2804 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This add support in the JS SDK for the
Llminterface in reference to the Spin PR fermyon/spin#1731