Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update sqlite return types to be more ergonomic #185

Merged
merged 1 commit into from
Sep 11, 2023
Merged

update sqlite return types to be more ergonomic #185

merged 1 commit into from
Sep 11, 2023

Conversation

karthik2804
Copy link
Collaborator

@karthik2804 karthik2804 commented Sep 1, 2023 •
edited
Loading

Changes the type to a hashmap of the column names.

fixes #183

@karthik2804 karthik2804 force-pushed the sqlite/update_return_types branch 2 times, most recently from fc4d65f to d75a468 Compare September 1, 2023 16:30
rylev
rylev requested changes Sep 4, 2023
View reviewed changes
Copy link

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is technically a breaking change. This feature is in private preview so perhaps that's fine, but I'd like to make sure we socialize this change widely before accepting it. If everyone is fine with the breaking change, this looks good to me.

dicej
dicej approved these changes Sep 11, 2023
View reviewed changes
Copy link

@dicej dicej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that both the SDK itself and the SQLite feature are still considered "experimental", I think it's reasonable to make a breaking change to improve the API.

@karthik2804 karthik2804 merged commit 31565a6 into fermyon:main Sep 11, 2023
2 checks passed
@karthik2804 karthik2804 deleted the sqlite/update_return_types branch September 11, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rylev rylev rylev approved these changes

@dicej dicej dicej approved these changes

@radu-matei radu-matei Awaiting requested review from radu-matei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqliteReturn type uses tuple with union type instead of an array type
3 participants
@karthik2804 @dicej @rylev