introduce sessionv2, written in typescript, for compatibility with latest spin #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endocrimes
force-pushed
the
dani/sessionv2
branch
from
7cc68be
to
1de5ac8
Compare
vdice
reviewed
Sep 19, 2024
There was a problem hiding this comment.
@endocrimes this PR looks great! Thanks for updating the session module.
The only things I needed to build and deploy from my fork were CI/CD changes. Could you incorporate some or all? I can help create follow-ups for any remaining items.
- Rebase off of main to get recent build fix
- Need to install deps for sessionv2 in build.yml (eg vdice@5971a91)
- Use relative build.yml, not pinned to main, to get update above (eg vdice@24097a8) Actually this change was only needed on my fork... but could be useful when working off of a branch and testing CI.
- Bump to spin v2.7.0 in CI (eg vdice@8b2cc93)
- Otherwise I see the following when we
spin upusing the older 2.0.1 version to test the site: https://github.com/vdice/finicky-whiskers/actions/runs/10942569334/job/30379905619
- Otherwise I see the following when we
|
@vdice oh thanks for looking into that! - I'll try and find some time to port them over early next week 😅 |
|
@endocrimes if you'd like, I'd be happy to rebase the branch and merge the updates mentioned/linked above. Then we can get review(s) from others. |
technosophos
approved these changes
Sep 19, 2024
|
@vdice if you have the time that would be awesome 💜 |
Signed-off-by: Danielle Lancashire <[email protected]>
sessionv1 was written in Ruby, which is great for demo purposes, but currently relies on an out of date wasi-libc that is unsupported by latest spin. Switch to the new Typescript version with full-wasi support. Signed-off-by: Danielle Lancashire <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
Signed-off-by: Vaughn Dice <[email protected]>
vdice
force-pushed
the
dani/sessionv2
branch
from
1de5ac8
to
8d9ab8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionv1 was written in Ruby, which is great for demo purposes, but
currently relies on an out of date wasi-libc that is unsupported by
latest spin.
Switch to the new Typescript version with full-wasi support (keeping the Ruby version in the hopes that it can be bought back to life).