Add support for formatting output of cloud apps list and cloud apps info
#212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
vdice
approved these changes
Nov 5, 2024
itowlson
requested changes
Nov 5, 2024
…p lists are printed Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
Signed-off-by: Thorsten Hans <[email protected]>
|
Thanks for the reviews @vdice and @itowlson trying to mimic the behavior we have in place for plain text for json wasn't the smartest idea. I changed the way AppInfo is created and went with a simple String for Description instead of an Option it feels more natural to have a constant schema in JSON. Thanks once again @itowlson for all those great suggestions 💪🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
--formatflag (valuesPlain&Json) to the following commands:spin cloud apps listspin cloud apps info <app_name>The enum contains the
Plainvariant (which is also set as default value for both commands) due to backward compatibility reasons.