add optional configuration for content path #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: karthik2804 <[email protected]>
karthik2804
force-pushed
the
add_optional_configurations
branch
from
a644287
to
9391729
Compare
itowlson
approved these changes
Oct 25, 2023
| @@ -28,13 +28,14 @@ pub fn render(req: Request) -> Result<Response> { | |||
| _ => false, | |||
| }; | |||
|
|
|||
| let optinal_path_prefix = spin_sdk::config::get("optional_path_prefix").unwrap_or_default(); | |||
There was a problem hiding this comment.
typo
Suggested change
| let optinal_path_prefix = spin_sdk::config::get("optional_path_prefix").unwrap_or_default(); | |
| let optional_path_prefix = spin_sdk::config::get("optional_path_prefix").unwrap_or_default(); |
Although I'm not sure optional is helpful here. You're going to use the (Rust) variable regardless of what it contains. Just call it path_prefix.
I'd recommend doing the same for the Spin config/variable. When I read a manifest I'll either see a path_prefix or I won't.
There was a problem hiding this comment.
So my actual suggestion is
Suggested change
| let optinal_path_prefix = spin_sdk::config::get("optional_path_prefix").unwrap_or_default(); | |
| let path_prefix = spin_sdk::config::get("path_prefix").unwrap_or_default(); |
| // Get the request path. | ||
| let path_info = match req.headers().get("spin-path-info") { | ||
| Some(p) => { | ||
| if p == "/" { | ||
| DEFAULT_INDEX.to_owned() | ||
| format!("{}{}", optinal_path_prefix, DEFAULT_INDEX.to_owned()) |
There was a problem hiding this comment.
Consider pulling out the common prefixing operation e.g.
let path = if p == "/" { DEFAULT_INDEX.to_owned() } else { p.to_str()?.to_owned() }; // same as existing code
format!("{path_prefix}{path}")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.