Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: function naming change (is->check), code modularization #12

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

tooooo1
Copy link
Member

@tooooo1 tooooo1 commented Sep 12, 2023

Summary

Implemented several codebase enhancements including renaming a key function for clarity, modularizing the codebase for better maintainability, and updating the demo to reflect these changes.

+Added jsdoc

future work: checkSupport func develop

Checks

Please check the following:

  • I have written documents and tests, if needed.

@tooooo1 tooooo1 requested a review from manudeli as a code owner September 12, 2023 08:05
@tooooo1 tooooo1 self-assigned this Sep 12, 2023
@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2023

🦋 Changeset detected

Latest commit: ba5e72d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fepack/image Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@netlify
Copy link

netlify bot commented Sep 12, 2023

Deploy Preview for fepack ready!

Name Link
🔨 Latest commit ba5e72d
🔍 Latest deploy log https://app.netlify.com/sites/fepack/deploys/650130aa7163a70008ed2a8b
😎 Deploy Preview https://deploy-preview-12--fepack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tooooo1 tooooo1 linked an issue Sep 12, 2023 that may be closed by this pull request
@tooooo1 tooooo1 enabled auto-merge (squash) September 12, 2023 08:06
@tooooo1 tooooo1 disabled auto-merge September 12, 2023 08:06
@tooooo1 tooooo1 enabled auto-merge (squash) September 12, 2023 08:21
@tooooo1 tooooo1 disabled auto-merge September 12, 2023 09:02
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #12 (ba5e72d) into main (c08a063) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #12   +/-   ##
=======================================
  Coverage   50.00%   50.00%           
=======================================
  Files           1        2    +1     
  Lines          12       12           
  Branches        2        2           
=======================================
  Hits            6        6           
  Misses          5        5           
  Partials        1        1           
Components Coverage Δ
@fepack/image 50.00% <50.00%> (ø)

@tooooo1 tooooo1 merged commit bcd9788 into main Sep 13, 2023
@tooooo1 tooooo1 deleted the refactor/image-module-structure branch September 13, 2023 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: function naming change, code modularization
2 participants