feat: first draft on improving error messages #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fent
reviewed
Jan 26, 2022
| export type defaultOptions = Miniget.Options; | ||
| export type MinigetError = Error; | ||
| export type httpLibs = { [key: string]: HTTPLib }; |
There was a problem hiding this comment.
this is exported for the tests right? look at https://github.com/fent/node-muk-require
it would work something like
const badMiniget = muk('../', {
http: null,
https: null,
});There was a problem hiding this comment.
i know about mocking - have only used proxies for it though and that was just awful...
only problem is that library is not ts campatible😉
There was a problem hiding this comment.
i'll ask the author if they wanna convert to ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes ##63