Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support default in alias extractors #620

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

nonibansal
Copy link
Contributor

@nonibansal nonibansal commented Dec 27, 2024

Important

Add support for default values in alias extractors, update protobufs, and add tests.

  • Behavior:
    • Support default values in alias extractors in featureset.py.
    • Update _validate() in Featureset to check default values for alias extractors.
    • Modify _extractor_to_proto() in to_proto.py to handle AliasInfo.
  • Protobuf:
    • Add AliasInfo message to featureset_pb2.py and featureset_pb2.pyi.
    • Update Extractor message to include alias_info.
  • Tests:
    • Add test_alias_extractor_with_default_value in test_featureset.py.
    • Add test_invalid_default_alias_extractor in test_invalid_featureset.py.
  • Misc:
    • Update version to 1.5.65 in pyproject.toml.

This description was created by Ellipsis for 5afb0b2. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 5afb0b2 in 1 minute and 24 seconds

More details
  • Looked at 618 lines of code in 10 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. fennel/featuresets/featureset.py:90
  • Draft comment:
    Consider adding a check to ensure args is not empty before accessing args[0] to prevent potential IndexError.
  • Reason this comment was not posted:
    Comment was not on a valid diff hunk.
2. fennel/featuresets/featureset.py:534
  • Draft comment:
    Consider adding a check to ensure args is not empty before accessing args[0] to prevent potential IndexError.
  • Reason this comment was not posted:
    Marked as duplicate.
3. fennel/featuresets/featureset.py:804
  • Draft comment:
    Consider adding a check to ensure args is not empty before accessing args[0] to prevent potential IndexError.
  • Reason this comment was not posted:
    Marked as duplicate.
4. fennel/featuresets/featureset.py:983
  • Draft comment:
    Consider adding a check to ensure args is not empty before accessing args[0] to prevent potential IndexError.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_beocNDsGMlWCNXZs


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant