Support default in alias extractors #620
Open
+271
−57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add support for default values in alias extractors, update protobufs, and add tests.
featureset.py
._validate()
inFeatureset
to check default values for alias extractors._extractor_to_proto()
into_proto.py
to handleAliasInfo
.AliasInfo
message tofeatureset_pb2.py
andfeatureset_pb2.pyi
.Extractor
message to includealias_info
.test_alias_extractor_with_default_value
intest_featureset.py
.test_invalid_default_alias_extractor
intest_invalid_featureset.py
.1.5.65
inpyproject.toml
.This description was created by for 5afb0b2. It will automatically update as commits are pushed.