aggregation: add warnings for aggregations on top of keyed datasets

[nonibansal]

Important

Add warnings for aggregations on keyed datasets in visitAggregate and update version to 1.5.61.

• Behavior:
  • Add warning in visitAggregate in datasets.py for aggregations on keyed datasets unless all windows are discrete forever or along is set.
  • Update logic to determine all_discrete, all_continuous, and all_discrete_forever in visitAggregate.
  • Modify is_terminal condition to use all_continuous in visitAggregate.
• Versioning:
  • Update version to 1.5.61 in pyproject.toml and CHANGELOG.md.

^{This description was created by for 16e8cb6. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 7d5e761 in 40 seconds

More details

• Looked at 73 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. fennel/datasets/datasets.py:2925

• Draft comment:
  The condition for issuing a warning is incorrect. It should warn if along is None and not all windows are discrete forever, regardless of the timestamp check. The current logic will not warn if along is set to a non-timestamp field, which is not the intended behavior.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

Workflow ID: wflow_LZj3qTV6YHynak9z

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 57ed51f in 42 seconds

More details

• Looked at 73 lines of code in 1 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. fennel/datasets/datasets.py:2925

• Draft comment:
  The warning logic is incorrect. It should warn if 'along' is None and not all windows are discrete forever, or if 'along' is set to the timestamp field. The current condition will not trigger the warning correctly in all cases.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

Workflow ID: wflow_h7tE9brPc3gKnC1v

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

❌ Changes requested. Incremental review on e00ca45 in 54 seconds

More details

• Looked at 100 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_IrLN5GhRLh3wJ3rj

---

Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 16e8cb6 in 54 seconds

More details

• Looked at 100 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 2 drafted comments based on config settings.

1. fennel/CHANGELOG.md:3

• Draft comment:
  The version number here should be 1.5.60 to match the PR description and the changes made in pyproject.toml.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment is asking for a change based on information not present in the diff. The changelog entry for 1.5.61 seems consistent with the rest of the file. Without seeing the PR description or pyproject.toml, I cannot verify the comment's claim.
  I might be missing context from the PR description or pyproject.toml, but the comment does not provide strong evidence for a required change based on the diff alone.
  The comment relies on external context not provided in the diff, which makes it speculative. The changelog entry appears correct within the context of the file.
  Delete the comment because it relies on external context not present in the diff and does not provide strong evidence for a required change.

2. pyproject.toml:3

• Draft comment:
  The version number here should be 1.5.60 to match the PR description.
• Reason this comment was not posted:
  Marked as duplicate.

Workflow ID: wflow_ApQ2lS6KZyVFOr7K

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.