Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add support for stacked sinks (#611)" #612

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

saiharshavellanki
Copy link
Contributor

@saiharshavellanki saiharshavellanki commented Dec 6, 2024

This reverts commit 725eb40.


Important

Reverts support for stacked sinks, removing related code, tests, and documentation, and updates version to 1.5.58.

  • Behavior:
    • Reverts support for stacked sinks by removing stacked parameter from sink() in connectors.py.
    • Removes validation logic for stacked sinks in to_proto.py.
  • Documentation:
    • Deletes sink.py example demonstrating stacked sinks.
    • Removes stacked option from sink.md and concepts/sink.md.
  • Tests:
    • Removes tests related to stacked sinks in test_connectors.py and test_invalid_connectors.py.
  • Misc:
    • Reverts version in pyproject.toml from 1.5.59 to 1.5.58.
    • Updates connector_pb2.py and connector_pb2.pyi to remove stacked field.

This description was created by Ellipsis for 9eec586. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 9eec586 in 1 minute and 14 seconds

More details
  • Looked at 659 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_WHn2ulMmk376Iq7O


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@saiharshavellanki saiharshavellanki merged commit af3c39e into main Dec 6, 2024
8 checks passed
@saiharshavellanki saiharshavellanki deleted the harsha/revert_stacked_sinks branch December 6, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants