Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

client: Report error response only once in sync and extract features call #305

Merged
merged 1 commit into from
Nov 18, 2023
Merged

client: Report error response only once in sync and extract features call #305

merged 1 commit into from
Nov 18, 2023

Conversation

mohitreddy1996
Copy link
Contributor

@mohitreddy1996 mohitreddy1996 commented Nov 18, 2023 •
edited
Loading

check_response is already called in _get and _post methods which are used by all the REST calls from the client

For a single extract features call, I see two error statements -

Server returned: 500, Internal Server Error, error: FeatureSet not found: UserPageViewFeaturesFSDS
Server returned: 500, Internal Server Error, error: FeatureSet not found: UserPageViewFeaturesFSDS

Similarly see such errors for sync call in case sync fails completely

@aditya-nambiar aditya-nambiar merged commit dbaff63 into main Nov 18, 2023
7 checks passed
@aditya-nambiar aditya-nambiar deleted the mohit/report-error-once branch November 18, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditya-nambiar aditya-nambiar aditya-nambiar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohitreddy1996 @aditya-nambiar