Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join: Handle conflict in LHS value and RHS key #301

Merged
merged 1 commit into from
Nov 13, 2023
Merged

join: Handle conflict in LHS value and RHS key #301

merged 1 commit into from
Nov 13, 2023

Conversation

aditya-nambiar
Copy link
Contributor

No description provided.

@nikhilgarg28
Copy link
Contributor

Just to confirm, if there is a column in left that has same name as non-key column of right, such that after join two columns will have the same name, we will still flag that as an error, right?

Also, not sure what the error message is right now but might be good to add a reference to using rename operator before joining.

@aditya-nambiar
Copy link
Contributor Author

Yes we do. We already have the preventions/errors in place. The issue this time was a tricky one

LHS key account id joined with the RHS key id, but LHS had id as a value field too.

So pandas made it id_x.

The join is semantically correct since we should just drop the id from RHS after the join. So the PR only fixes the execution aspect

@nikhilgarg28
Copy link
Contributor

Understood, thanks for explaining.

@aditya-nambiar aditya-nambiar merged commit 42e9391 into main Nov 13, 2023
5 checks passed
@aditya-nambiar aditya-nambiar deleted the aditya/join-big branch November 13, 2023 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bothra90 bothra90 bothra90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aditya-nambiar @nikhilgarg28 @bothra90