source: Support since param in sources #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fennel/CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.18.10] - 2023-10-20 | |||
| - Add support for `starting_from` in S3 source. | |||
There was a problem hiding this comment.
Suggest to call this starting instead of starting_from?
There was a problem hiding this comment.
Actually 'since' and 'until' may be even better? ('starting' is fine too but 'ending' doesn't roll off that well)
aditya-nambiar
changed the title
aditya-nambiar
force-pushed
the
aditya/starting_from
branch
from
7073178 to
7cd6d79
Compare
bothra90
approved these changes
Oct 27, 2023
fennel/CHANGELOG.md
Outdated
| @@ -1,5 +1,7 @@ | |||
| # Changelog | |||
|
|
|||
| ## [0.18.10] - 2023-10-20 | |||
| - Add support for `starting_from` in S3 source. | |||
aditya-nambiar
force-pushed
the
aditya/starting_from
branch
from
7cd6d79 to
2df1063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.