Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add backend support for icons #52

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

kingwrg
Copy link

@kingwrg kingwrg commented Jul 11, 2024

Pull Request Summary

Backend Changes

  1. Model Changes:

    • Goal Model:
      • Added a new Icon property to store the goal's icon.
  2. Controller Changes:

    • GoalController:
      • Added a new endpoint to update the Icon property of a goal.
      • Introduced UpdateIconRequest class to handle the icon update request.
  3. Service Changes:

    • GoalsService:
      • Updated the UpdateAsync method to support partial updates using UpdateDefinition.
    • IGoalsService Interface:
      • Modified the UpdateAsync method signature to accept UpdateDefinition<Goal>.
  4. Configuration Changes:

    • Updated the MongoDB connection string in the configuration file.
  5. Testing Changes:

    • FakeGoalsService:
      • Implemented a simulated UpdateAsync method.
    • GoalControllerTests:
      • Changed test methods' return type to async Task for proper async handling.

Summary

  • Extended the backend to support new API endpoints for updating goal icons.
  • Integrated the frontend with the new backend endpoints.
  • Added tests to verify the backend and frontend integration, ensuring proper async handling in test methods.

Copy link

gitguardian bot commented Jul 11, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
- - MongoDB Credentials 1e4fd13 CommBank-Server/Secrets.json View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant