RFC: Add cista::*::cstring type #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your PR! I think some tests would be useful, formatting should be fixed (using clang-format), and maybe a bit of description in the code how it works could help me to understand what's going on (just the tricky spots where the magic happens). |
khng300
force-pushed
the
add-cstring-rfc
branch
from
86cabee to
425fea0
Compare
khng300
force-pushed
the
add-cstring-rfc
branch
4 times, most recently
from
50e0454 to
0079634
Compare
felixguendling
requested changes
Nov 15, 2023
khng300
force-pushed
the
add-cstring-rfc
branch
from
0079634 to
860c622
Compare
felixguendling
approved these changes
Nov 24, 2023
|
Still in draft mode. Something missing? |
|
I was considering if it is still worth keeping cstring_view in such case. If not, the corner case of checking null can be omitted. |
khng300
force-pushed
the
add-cstring-rfc
branch
from
860c622 to
6445e73
Compare
khng300
force-pushed
the
add-cstring-rfc
branch
2 times, most recently
from
c07e7e7 to
c8cef18
Compare
The latest commit pulled out the null-pointer checks for set_owning related calls(). |
khng300
force-pushed
the
add-cstring-rfc
branch
2 times, most recently
from
befa740 to
4caf71b
Compare
This new type is able to store a trailing \0 character, without compromising one byte for storage when the string is a small-string. Storage of NUL character within data is also supported. This is inspired by felixguendling#187 (comment). See felixguendling#187.
khng300
force-pushed
the
add-cstring-rfc
branch
from
4caf71b to
e6ee954
Compare
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new type is able to store a trailing \0 character, without compromising one byte for storage when the string is a small-string.
Storage of NUL character within data is also supported.
This is inspired by
#187 (comment).
See #187.