Merge pull request #11 from HughePaul/bugfix/issue-10

Set default timestamp when both time and callback are omitted
felixge · Mar 9, 2018 · 4b32088 · 4b32088
2 parents bf8bfc5 + 07aee8b
commit 4b32088
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -2,3 +2,5 @@ language: node_js
 node_js:
   - 0.4
   - 0.6
+  - 4
+  - 8
diff --git a/lib/GraphiteClient.js b/lib/GraphiteClient.js
@@ -59,9 +59,12 @@ GraphiteClient.appendTags = function(flatMetrics, tags) {
 GraphiteClient.prototype.write = function(metrics, timestamp, cb) {
   if (typeof timestamp === 'function') {
     cb = timestamp;
-    timestamp = Date.now();
+    timestamp = null;
   }
 
+  // default timestamp to now
+  timestamp = timestamp || Date.now();
+
   // cutting timestamp for precision up to the second
   timestamp = Math.floor(timestamp / 1000);
 

diff --git a/package.json b/package.json
@@ -10,7 +10,9 @@
   },
   "main": "./index",
   "scripts": {
-    "test": "make test"
+    "test": "npm run test:unit && npm run test:integration",
+    "test:unit": "make test type=unit",
+    "test:integration": "make test type=integration"
   },
   "engines": {
     "node": "*"
-Original file line number
+Diff line change
@@ Expand Up / @@ -2,3 +2,5 @@ language: node_js @@
     node_js:
       - 0.4
       - 0.6
+      - 4
+      - 8