Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compatibility with android 12 and up #361

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ImperialCrise
Copy link

This pull request contains a fix for a crash I discovered when the application was asking to access the USB interface with an android version greater than or equal to 12.

Indeed, it was missing the update of the new Android security and the setting of a special flag for this kind of case.

I have also performed tests to ensure that the fix did not cause any other problems and that everything works as expected.
Thanks for considering this pull request.

Copy link

@SutliffeProductions SutliffeProductions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@Garrett67
Copy link

Great catch. I can confirm that everything works on Android 13 now.

Copy link

@apxcoder apxcoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could we get this merged? It solves the Android 13 issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants