Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dev] 유저 api 작업 #30

Open
wants to merge 6 commits into
base: feature/api-integration-20-3
Choose a base branch
from

Conversation

kyubumjang
Copy link
Contributor

@kyubumjang kyubumjang commented Oct 6, 2024

#️⃣ 연관된 이슈

#20 API 연동

📝 작업 내용

  • 로그인 유저 정보 가져오기 API
  • 유저 현재 위치 업데이트 API
  • 유저 정보 업데이트(닉네임, 현재 위치) API
  • nickname validation check API
  • 닉네임 업데이트 API
  • 해당 API 필요한 페이지 업데이트 (signup page, user mypage)

스크린샷

💬 리뷰 요구사항

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

@kyubumjang kyubumjang self-assigned this Oct 6, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2024

Deploying sijak with  Cloudflare Pages  Cloudflare Pages

Latest commit: 62d2924
Status:🚫  Build failed.

View logs

profile_image:
"https://avatars.githubusercontent.com/u/33307948?s=400&u=a642bbeb47b47e203f37b47db12d2d92d8f98580&v=4",
name: "kyubumjang",
const [loginedUser, setLoginedUser] = useState<LoginUserInfo>({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

유저 정보와 관련된 코드들은 useUserInfo와 같이 커스텀 훅으로 만들어서 사용하셔도 될 것 같아요

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

그리고 해당 컴포넌트가 가독성이 좋지않아 form 관련코드를 따로 컴포넌트로 생성하는게 좋아보여요

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants