Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] lecture 관련 API 작업 #27

Open
wants to merge 4 commits into
base: feature/api-integration-20
Choose a base branch
from
Open

[Dev] lecture 관련 API 작업 #27

wants to merge 4 commits into from

Conversation

kyubumjang
Copy link
Contributor

@kyubumjang kyubumjang commented Oct 6, 2024 •
edited
Loading

#️⃣ 연관된 이슈

#20 API 연동

📝 작업 내용

  • lecture API 타입
  • lecture api request
  • lecture api hooks - useQuery, useMutation
  • 홈 주변 클래스 리스트 가져오기, 시작 픽 클래스 가져오기, 전체 클래스 가져오기, 클래스 상세 정보 가져오기

스크린샷

💬 리뷰 요구사항

  • 타입 관련해서 리팩토링 진행 예정입니다. 아래와 같이 겹치는 부분이 꽤 있는 것 같아서 코드 리팩토링 이슈 [Dev] 코드 리팩토링 #25 에서 진행 예정입니다.
status: number;
message: string;
data: T;

@kyubumjang kyubumjang self-assigned this Oct 6, 2024
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Oct 6, 2024 •
edited
Loading

Deploying sijak with  Cloudflare Pages  Cloudflare Pages

Latest commit: 46f6517
Status:🚫  Build failed.

View logs

@kyubumjang kyubumjang changed the title Feature/api integration 20 1 [Dev] lecture 관련 API 작업 내역 - 홈 주변 클래스 리스트 가져오기, 시작 픽 클래스 가져오기, 전체 클래스 가져오기, 클래스 상세 정보 가져오기 Oct 6, 2024
@kyubumjang kyubumjang changed the title [Dev] lecture 관련 API 작업 내역 - 홈 주변 클래스 리스트 가져오기, 시작 픽 클래스 가져오기, 전체 클래스 가져오기, 클래스 상세 정보 가져오기 [Dev] lecture 관련 API 작업 Oct 6, 2024
@kyubumjang kyubumjang changed the base branch from feature/api-integration-20 to develop October 6, 2024 18:47
Jayden11v
Jayden11v reviewed Oct 7, 2024
View reviewed changes
src/entities/lecture/model/lecture.ts
}

export interface LectureInfo {
id: number;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id같은 경우에는 number타입보단 ID 타입을 사용하는 게 더 좋습니다.

Jayden11v
Jayden11v reviewed Oct 7, 2024
View reviewed changes
src/entities/lecture/api/index.ts
payload,
}: {
lectureId: number;
payload: GetLecture["Request"]["body"];
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다 이와같이 타입을 정의하셨는데 GetLecturePayload와 같이 타입을 정의하시는게 나을 것 같아요

@kyubumjang kyubumjang changed the base branch from develop to feature/api-integration-20 October 9, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jayden11v Jayden11v Jayden11v left review comments

Assignees

@kyubumjang kyubumjang

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kyubumjang @Jayden11v