WIP for discussion #46
Conversation
| @@ -221,10 +226,10 @@ module.exports = exports = (log, loga, argv) -> | |||
| displayName: extractUserInfo(argv.oauth2_DisplayNameField, 'params.user_id') | |||
| } | |||
| } | |||
| cb(null, user) | |||
There was a problem hiding this comment.
This here is the function call that puts the user on req.session.passport.user, where it's later showing up undefined. The change here is a little sus, in that cb is now only getting called in the try block, and will never call back on error. The old way is a little odd too in that it could add a partial user object w/o all of the expected information. This should probably call cb(e) in the catch block.
It seems likely that what's happening is that something is throwing an error in here and the feedback isn't getting to the client, is there any info in the error output from the server?
| @@ -185,13 +190,17 @@ module.exports = exports = (log, loga, argv) -> | |||
| userInfoURL: argv.oauth2_UserInfoURL | |||
| }, (accessToken, refreshToken, params, profile, cb) -> | |||
|
|
|||
| token = jwtDecode(accessToken) | |||
There was a problem hiding this comment.
This decode probably needs to be in a try to avoid throwing on bad tokens.
|
The other thing to look at other than the server error logs would be the |
|
Looking back for the last time I can say with certainty that claim was working, was mid March which would have been with 0.6.2 |
|
It was a thought, but the current version works correctly, allowing claim with a github login. Looks as if the issue is isolated to the oauth2 login. @Bortseb, @3-w-c If you can identify a know working version of the oauth2 code for which claim works, you should be able to use |
Mirrored here for discussion and debugging