Update frame.js #17
Open
Update frame.js #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the frame item with the #miro link on this page http://robert.wiki.openlearning.cc/import-miro-graphs.html not show an internal scroll bar when the frame HEIGHT parameter is 0. I was trying to make the frame for a simple link as small as possible. I also notice that frames that are beside each other on the page like the one above just sort of blend together and look like one larger frame. I also noticed an empty <p></p> for each frame items on the page after the iframe element in the HTML, not sure what's adding that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the frame item with the #miro link on this page not show an internal scroll bar when the frame HEIGHT parameter is 0. I was trying to make the frame for a simple link as small as possible. I also notice that frames that are beside each other on the page like the one above just sort of blend together and look like one larger frame. I also noticed an empty
for each frame items on the page after the iframe element in the HTML, not sure what's adding that.