prevent default for alt-s #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@WardCunningham alt-s perfect solution on ChromeOS. Thank you I'm using ChromeOS version 60.0.3112.80 (Official Build) beta (64-bit) on Samsung Chromebox series 3. I have 3 more commonly used ChromeOS computers. Will test and report anything odd (super unlikely) |
|
@cliveb I'm going to assume that you have not spotted anything odd. |
|
Correct. alt-s is good across all my chromeOS devices.
…On Sun, Aug 13, 2017 at 11:27 AM, Paul Rodwell ***@***.***> wrote:
@cliveb <https://github.com/cliveb> I'm going to assume that you have not
spotted anything odd.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#198 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAsyrrdkCINLNCvRYojnDHfAKj-r4_fPks5sX0ANgaJpZM4Ouw0C>
.
|
|
Thank you - merging... |
|
Published as + [email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We prevent the default alt-s handling when saving edits. This commit mimics the adjacent alt-i handling. This seems harmless and safe to merge even though it has not yet been tested on the device where the unwanted event propagation issue was reported, #183.
@cliveb