Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruff: use extend-include option for non-*.py files #25

Merged
merged 1 commit into from
Aug 28, 2024
Merged

ruff: use extend-include option for non-*.py files #25

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions vcs-diff-lint
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,10 +185,19 @@ class RuffLinter(_Linter):
def is_compatible(self, file):
return file.type == 'python'

def command(self, projectdir, _filenames):
def command(self, projectdir, filenames):
cmd = [CSDIFF_RUFF]
# Construct --config 'extend-include=["a", "b", ...]' option
# per https://github.com/astral-sh/ruff/issues/13122
explicitly_include = [fn for fn in filenames if not fn.endswith("*.py")]
if explicitly_include:
extend_include = ','.join([f'"{fn}"' for fn in explicitly_include])
extend_include = f'extend-include=[{extend_include}]'
cmd += ["--config", extend_include]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to use a config option or can we use --extend-exclude?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, this is extend include 🤷

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see --extend-include in --help.


# While we optimize other analyzers and we scan only the changed
# set of files, Ruff is fast enough to do full-projectdir scan.
cmd = [CSDIFF_RUFF] + [os.path.join(self.gitroot, projectdir)]
cmd.append(os.path.join(self.gitroot, projectdir))
return cmd, {}


Expand Down
Loading