Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for Pulp manual createrepo #3549

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Implement support for Pulp manual createrepo #3549

wants to merge 1 commit into from

Conversation

FrostyX
Copy link
Member

@FrostyX FrostyX commented Dec 6, 2024

Fix #3498

@FrostyX FrostyX added the pulp label Dec 6, 2024
@FrostyX FrostyX changed the title backend, frontend: implement support for Pulp manual createrepo Implement support for Pulp manual createrepo Dec 6, 2024
@FrostyX
Copy link
Member Author

FrostyX commented Dec 6, 2024

I just wanted to push a proof of concept. This still needs to fix some quirks and refactor the code. Worth mentioning:

  • This approach of having two separate repositories and "copying packages from one to another" was recommended by Dennis
  • Currently we use fedora-rawhide-x86_64/devel/ directories on backend, but Pulp has a problem with that because the devel directory would encroach an existing repository. So that I used fedora-rawhide-x86_64_devel/ naming. I don't like it very much.

@FrostyX FrostyX force-pushed the pulp-manual-createrepo branch from 883af5b to c6d1644 Compare December 6, 2024 17:06
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
backend/copr_backend/storage.py
return False
return True

def _copy_packages_from_devel(self, repository, dirname, chroot):

Check warning

Code scanning / vcs-diff-lint

PulpStorage._copy_packages_from_devel: Either all return statements in a function should return an expression, or none of them should. Warning

PulpStorage._copy_packages_from_devel: Either all return statements in a function should return an expression, or none of them should.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pulp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pulp - Manual createrepo (devel sub-directory)
1 participant
@FrostyX