Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depend on git-core instead of git #3543

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

xsuchy
Copy link
Member

@xsuchy xsuchy commented Dec 4, 2024

Copy link
Member

@nikromen nikromen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like every use-case we need in rpmbuild is covered in git-core

@praiskup
Copy link
Member

From the change:

Many package have either requirement or build requirement for the git binary. The git package is complex and is divided in mulitple subpackages. The subpackage that contains the git binary, that is enough for most of the use cases, is part of the git-core subpackage.

We are only using git as a command; but it is not clear what commands are provided by git and git-core itself.

Hard to review, therefore I am not sure if the change is worth the risk 🤷

@nikromen
Copy link
Member

but it is not clear what commands are provided by git and git-core itself

true that they didn't mention it. I just installed git-core inside container and tried it there

@praiskup
Copy link
Member

I just installed git-core inside container and tried it there

What commands have you tested? Via Beaker tests? Is submodule handling covered? Something tells me we already added LFS support for clones, not sure.

The change proposal doesnt answer. 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants