Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messaging: summary is missing propery decorator #3530

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

nikromen
Copy link
Member

Fixes #3493

@nikromen
Copy link
Member Author

nikromen commented Nov 25, 2024

@abompard per this comment - with the property decorator we should get a reasonable description from summarry, instead of something like:

<bound method BuildChrootStarted.summary of
 BuildChrootStartedV1(id='702cc3bd-450e-44bb-82cf-b92ba4a67e11',
 topic='org.fedoraproject.prod.copr.build.start', body={'user': 'davidsch',
 'copr': 'fixes4bout', 'owner': 'davidsch', 'pkg': None, 'build': 8190255,
 'chroot': 'srpm-builds', 'version': None, 'status': 3, 'ip':
 'xxxxx, 'who':
 'backend.worker-rpm_build_worker:xxxx', 'pid': xxxx, 'what': 'build
 start: user:davidsch copr:fixes4bout pkg:None build:xxxxx
 ip:xxxxx pid:14xxxx'})>

right?

@abompard
Copy link
Contributor

Correct!

Copy link
Member

@praiskup praiskup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@praiskup praiskup merged commit 526473b into fedora-copr:main Nov 28, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fedora notifications (messages) contain very long subject
3 participants