Implement a check for every storage whether a repository is available #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…available
Otherwise, builds in Pulp projects will fail with this:
Waiting for copr_base repository
Waiting for copr_base repository
Backend process error: Giving up waiting for copr_base repository
So far it worked only because we didn't create Pulp projects directly
but rather migrated existing projects into Pulp and therefore this
path existed on the backend.
FrostyX
force-pushed
the
fix-pulp-storage
branch
from
682d6f5 to
ccbb6ac
Compare
praiskup
reviewed
Nov 22, 2024
| @@ -172,6 +180,11 @@ def delete_builds(self, dirname, chroot_builddirs, build_ids): | |||
| self.log.debug("can't remove %s", log_path) | |||
| return result | |||
|
|
|||
| def repository_exists(self, chroot): | |||
| repodata = os.path.join(self.opts.destdir, self.owner, self.project, | |||
There was a problem hiding this comment.
Is self.project actually a self.coprdir?
There was a problem hiding this comment.
It's actually this:
copr/backend/copr_backend/actions.py
Line 100 in e123e4e
which comes from frontend
copr/backend/copr_backend/actions.py
Line 100 in e123e4e
so it should only be a project name, not CoprDir name. Which should IMHO be what we want because CoprDirs don't have their own repositories available (see #3369) and they use the main repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, builds in Pulp projects will fail with this:
So far it worked only because we didn't create Pulp projects directly but rather migrated existing projects into Pulp and therefore this path existed on the backend.